pr: [Nightly Fix] - Bug - Fix Dashboard Widget Permission Check Typo#53
Open
jewel-claw wants to merge 1 commit intomasterfrom
Open
pr: [Nightly Fix] - Bug - Fix Dashboard Widget Permission Check Typo#53jewel-claw wants to merge 1 commit intomasterfrom
jewel-claw wants to merge 1 commit intomasterfrom
Conversation
'get_sumissions' → 'get_submissions' The typo caused AccessControl::hasEndPointPermission() to always return false for the 'submissions' group since 'get_sumissions' is not a registered endpoint. Non-admin users with wpf submission permissions were never shown the dashboard widget even when they had the correct capability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Typo:
'get_sumissions'→'get_submissions'inDashboardWidgetModule::addWidget().AccessControl::hasEndPointPermission()looks up the endpoint name against the registered permission map for the 'submissions' group. Because'get_sumissions'(missing 'b') does not exist in that map, the method always returnedfalsefor non-admin users.Effect: Any user with
wpf_can_view_all_entriesor related submission permissions would never see the WPPayForm dashboard widget, even though they should. Admins were unaffected because they have grand access viahasGrandAccess().